r56285 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56284‎ | r56285 | r56286 >
Date:01:26, 14 September 2009
Author:emufarmers
Status:ok (Comments)
Tags:
Comment:
(Bug 20634) Give the installer-created database user CREATE TABLE and ALTER TABLE rights so that upgrades will go more smoothly.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/users.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -496,6 +496,8 @@
497497 * (bug 482) Don't include TOC in the printable version if it has been hidden
498498 * Adjust the time according to the user configuration on Special:Revisiondelete
499499 * (bug 20624) Installation no longer allows "qqq" as the chosen language
 500+* (bug 20634) The installer-created database user will now have CREATE TABLE
 501+ and ALTER TABLE rights so that upgrades will go more smoothly.
500502
501503 == API changes in 1.16 ==
502504
Index: trunk/phase3/maintenance/users.sql
@@ -4,9 +4,9 @@
55 -- from local settings.
66 --
77
8 -GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES ON `{$wgDBname}`.*
 8+GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES,CREATE TABLE,ALTER TABLE ON `{$wgDBname}`.*
99 TO '{$wgDBuser}'@'%' IDENTIFIED BY '{$wgDBpassword}';
10 -GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES ON `{$wgDBname}`.*
 10+GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES,CREATE TABLE,ALTER TABLE ON `{$wgDBname}`.*
1111 TO '{$wgDBuser}'@localhost IDENTIFIED BY '{$wgDBpassword}';
12 -GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES ON `{$wgDBname}`.*
 12+GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES,CREATE TABLE,ALTER TABLE ON `{$wgDBname}`.*
1313 TO '{$wgDBuser}'@localhost.localdomain IDENTIFIED BY '{$wgDBpassword}';

Follow-up revisions

RevisionCommit summaryAuthorDate
r56323Follow up to r56285: just grant all rights to the installer-created database ...emufarmers18:40, 14 September 2009

Comments

#Comment by Simetrical (talk | contribs)   15:03, 14 September 2009

Might we also need DROP TABLE sometimes? It's hardly more scary than DELETE. Why don't we just give *?

Status & tagging log