r56208 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56207‎ | r56208 | r56209 >
Date:21:03, 11 September 2009
Author:catrope
Status:ok
Tags:
Comment:
Make os_disableSuggestionsOn() work also when called before mwsuggest.js has even done its initialization
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/mwsuggest.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/mwsuggest.js
@@ -840,6 +840,11 @@
841841 // remove descriptor
842842 os_map[inputId] = null;
843843 }
 844+
 845+ // Remove the element from the os_autoload_* arrays
 846+ var index = os_autoload_inputs.indexOf(inputId);
 847+ if ( index >= 0 )
 848+ os_autoload_inputs[index] = os_autoload_forms[index] = '';
844849 }
845850
846851 /** Initialization, call upon page onload */
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1591,7 +1591,7 @@
15921592 * to ensure that client-side caches do not keep obsolete copies of global
15931593 * styles.
15941594 */
1595 -$wgStyleVersion = '239';
 1595+$wgStyleVersion = '240';
15961596
15971597
15981598 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r57177merge r56208, r56949 from trunk -- needed for UsabilityInitative babaco fixesbrion00:10, 1 October 2009

Status & tagging log