r57177 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57176‎ | r57177 | r57178 >
Date:00:10, 1 October 2009
Author:brion
Status:ok
Tags:
Comment:
merge r56208, r56949 from trunk -- needed for UsabilityInitative babaco fixes
Modified paths:
  • /branches/wmf-deployment/includes/DefaultSettings.php (modified) (history)
  • /branches/wmf-deployment/includes/MagicWord.php (modified) (history)
  • /branches/wmf-deployment/includes/parser/Parser.php (modified) (history)
  • /branches/wmf-deployment/languages/messages/MessagesEn.php (modified) (history)
  • /branches/wmf-deployment/skins/common/mwsuggest.js (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/skins/common/mwsuggest.js
@@ -840,6 +840,11 @@
841841 // remove descriptor
842842 os_map[inputId] = null;
843843 }
 844+
 845+ // Remove the element from the os_autoload_* arrays
 846+ var index = os_autoload_inputs.indexOf(inputId);
 847+ if ( index >= 0 )
 848+ os_autoload_inputs[index] = os_autoload_forms[index] = '';
844849 }
845850
846851 /** Initialization, call upon page onload */
Index: branches/wmf-deployment/includes/parser/Parser.php
@@ -2298,7 +2298,8 @@
22992299 * @private
23002300 */
23012301 function getVariableValue( $index, $frame=false ) {
2302 - global $wgContLang, $wgSitename, $wgServer, $wgServerName, $wgScriptPath;
 2302+ global $wgContLang, $wgSitename, $wgServer, $wgServerName;
 2303+ global $wgScriptPath, $wgStylePath;
23032304
23042305 /**
23052306 * Some of these require message or data lookups and can be
@@ -2513,6 +2514,8 @@
25142515 return $wgServerName;
25152516 case 'scriptpath':
25162517 return $wgScriptPath;
 2518+ case 'stylepath':
 2519+ return $wgStylePath;
25172520 case 'directionmark':
25182521 return $wgContLang->getDirMark();
25192522 case 'contentlanguage':
Index: branches/wmf-deployment/includes/MagicWord.php
@@ -64,6 +64,7 @@
6565 'server',
6666 'servername',
6767 'scriptpath',
 68+ 'stylepath',
6869 'pagename',
6970 'pagenamee',
7071 'fullpagename',
Index: branches/wmf-deployment/includes/DefaultSettings.php
@@ -1588,7 +1588,7 @@
15891589 * to ensure that client-side caches do not keep obsolete copies of global
15901590 * styles.
15911591 */
1592 -$wgStyleVersion = '239a';
 1592+$wgStyleVersion = '240';
15931593
15941594
15951595 # Server-side caching:
Index: branches/wmf-deployment/languages/messages/MessagesEn.php
@@ -297,6 +297,7 @@
298298 'server' => array( 0, 'SERVER' ),
299299 'servername' => array( 0, 'SERVERNAME' ),
300300 'scriptpath' => array( 0, 'SCRIPTPATH' ),
 301+ 'stylepath' => array( 0, 'STYLEPATH' ),
301302 'grammar' => array( 0, 'GRAMMAR:' ),
302303 'gender' => array( 0, 'GENDER:' ),
303304 'notitleconvert' => array( 0, '__NOTITLECONVERT__', '__NOTC__'),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56208Make os_disableSuggestionsOn() work also when called before mwsuggest.js has ...catrope21:03, 11 September 2009
r56949Add a {{STYLEPATH}} magic word; necessary for upcoming EditToolbar fixcatrope11:51, 26 September 2009

Status & tagging log