r55696 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55695‎ | r55696 | r55697 >
Date:14:29, 31 August 2009
Author:vyznev
Status:ok (Comments)
Tags:
Comment:
skip math-related tests if $wgUseTeX is set to false in LocalSettings: this probably means we don't have a working texvc program available
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -367,6 +367,12 @@
368368 $section = null;
369369 continue;
370370 }
 371+ if ( preg_match('/\\bmath\\b/i', $data['options']) && !$this->savedGlobals['wgUseTeX'] ) {
 372+ # don't run math tests if $wgUseTeX is set to false in LocalSettings
 373+ $data = array();
 374+ $section = null;
 375+ continue;
 376+ }
371377 $result = $this->runTest(
372378 $this->chomp( $data['test'] ),
373379 $this->chomp( $data['input'] ),

Comments

#Comment by Ilmari Karonen (talk | contribs)   14:37, 31 August 2009

Hmm, looks like the MW installation used to run the parser tests here on CodeReview has $wgUseTeX set to false even though it does have a working texvc available. Might want to fix that, even though it only makes a difference for one test at the moment.

#Comment by Brion VIBBER (talk | contribs)   23:43, 4 September 2009

Have now set, thanks for the catch. :D

Status & tagging log