r55695 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55694‎ | r55695 | r55696 >
Date:14:01, 31 August 2009
Author:vyznev
Status:ok
Tags:
Comment:
followup to r55694: forgot to mark the new functions private
Modified paths:
  • /trunk/phase3/maintenance/cleanupImages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/cleanupImages.php
@@ -101,11 +101,11 @@
102102 return $this->repo->getRootDirectory() . '/' . $this->repo->getHashPath( $name ) . $name;
103103 }
104104
105 - function imageExists( $name, $db ) {
 105+ private function imageExists( $name, $db ) {
106106 return $db->selectField( 'image', '1', array( 'img_name' => $name ), __METHOD__ );
107107 }
108108
109 - function pageExists( $name, $db ) {
 109+ private function pageExists( $name, $db ) {
110110 return $db->selectField( 'page', '1', array( 'page_namespace' => NS_FILE, 'page_title' => $name ), __METHOD__ );
111111 }
112112

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55694redo r45388 (hopefully) more cleanly (see also bug 16916: Unnecessary title d...vyznev13:58, 31 August 2009

Status & tagging log