r55584 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55583‎ | r55584 | r55585 >
Date:19:57, 25 August 2009
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 20380) Link to history/log action at the top of Special:RevisionDelete are new more displayed when when doing log suppression
They're useless since they're linking to Special:Log/xxx?action=history, Special:Log?page=Special:Log, etc.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -183,7 +183,7 @@
184184 protected function showConvenienceLinks() {
185185 global $wgOut, $wgUser, $wgLang;
186186 # Give a link to the logs/hist for this page
187 - if( $this->targetObj ) {
 187+ if( $this->targetObj && $this->targetObj->getNamespace() != NS_SPECIAL ) {
188188 $links = array();
189189 $logtitle = SpecialPage::getTitleFor( 'Log' );
190190 $links[] = $this->skin->linkKnown(
Index: trunk/phase3/RELEASE-NOTES
@@ -434,6 +434,8 @@
435435 DatabaseBase::getFlag() now have documentation
436436 * (bug 19966) MediaWiki:License-header is now used for the licensing header in
437437 the file description page instead of MediaWiki:License
 438+* (bug 20380) Link to history/log action at the top of Special:RevisionDelete
 439+ are new more displayed when when doing log suppression
438440
439441 == API changes in 1.16 ==
440442

Follow-up revisions

RevisionCommit summaryAuthorDate
r55607Follow-up r55584: seems that the "View logs for this page" link is useful eve...ialex17:37, 26 August 2009

Comments

#Comment by Mike.lifeguard (talk | contribs)   16:32, 26 August 2009

No, it does make sense to link to the deletion log for log suppression! See http://meta.wikimedia.org/w/index.php?title=Special%3ALog&type=delete&user=&page=Special%3ALog%2Fglobalauth

I've reopened the bug.

#Comment by Mike.lifeguard (talk | contribs)   16:33, 26 August 2009

Also, there is something funky going on with parsing comments here...

Status & tagging log