r55607 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55606‎ | r55607 | r55608 >
Date:17:37, 26 August 2009
Author:ialex
Status:ok
Tags:
Comment:
Follow-up r55584: seems that the "View logs for this page" link is useful even when doing log suppression :)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -183,7 +183,7 @@
184184 protected function showConvenienceLinks() {
185185 global $wgOut, $wgUser, $wgLang;
186186 # Give a link to the logs/hist for this page
187 - if( $this->targetObj && $this->targetObj->getNamespace() != NS_SPECIAL ) {
 187+ if( $this->targetObj ) {
188188 $links = array();
189189 $logtitle = SpecialPage::getTitleFor( 'Log' );
190190 $links[] = $this->skin->linkKnown(
@@ -192,22 +192,24 @@
193193 array(),
194194 array( 'page' => $this->targetObj->getPrefixedText() )
195195 );
196 - # Give a link to the page history
197 - $links[] = $this->skin->linkKnown(
198 - $this->targetObj,
199 - wfMsgHtml( 'pagehist' ),
200 - array(),
201 - array( 'action' => 'history' )
202 - );
203 - # Link to deleted edits
204 - if( $wgUser->isAllowed('undelete') ) {
205 - $undelete = SpecialPage::getTitleFor( 'Undelete' );
 196+ if ( $this->targetObj->getNamespace() != NS_SPECIAL ) {
 197+ # Give a link to the page history
206198 $links[] = $this->skin->linkKnown(
207 - $undelete,
208 - wfMsgHtml( 'deletedhist' ),
 199+ $this->targetObj,
 200+ wfMsgHtml( 'pagehist' ),
209201 array(),
210 - array( 'target' => $this->targetObj->getPrefixedDBkey() )
 202+ array( 'action' => 'history' )
211203 );
 204+ # Link to deleted edits
 205+ if( $wgUser->isAllowed('undelete') ) {
 206+ $undelete = SpecialPage::getTitleFor( 'Undelete' );
 207+ $links[] = $this->skin->linkKnown(
 208+ $undelete,
 209+ wfMsgHtml( 'deletedhist' ),
 210+ array(),
 211+ array( 'target' => $this->targetObj->getPrefixedDBkey() )
 212+ );
 213+ }
212214 }
213215 # Logs themselves don't have histories or archived revisions
214216 $wgOut->setSubtitle( '<p>' . $wgLang->pipeList( $links ) . '</p>' );
Index: trunk/phase3/RELEASE-NOTES
@@ -432,8 +432,8 @@
433433 DatabaseBase::getFlag() now have documentation
434434 * (bug 19966) MediaWiki:License-header is now used for the licensing header in
435435 the file description page instead of MediaWiki:License
436 -* (bug 20380) Link to history/log action at the top of Special:RevisionDelete
437 - are new more displayed when when doing log suppression
 436+* (bug 20380) Links to history/deleted edits at the top of
 437+ Special:RevisionDelete are no more displayed when when doing log suppression
438438 * (bug 8143) Localised parser function names are now correctly case insensitive
439439 if they contain non-ASCII characters
440440

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55584* (bug 20380) Link to history/log action at the top of Special:RevisionDelete...ialex19:57, 25 August 2009

Status & tagging log