r55527 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55526‎ | r55527 | r55528 >
Date:12:53, 23 August 2009
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
* for php2js, all colons in messages will be replaced by " : ". That's not really needed. Commented out and added FIXME. Was introduced in r55290.
* update command line output
Modified paths:
  • /trunk/phase3/js2/mwEmbed/php/maintenance/mergeJavascriptMsg.php (modified) (history)

Diff [purge]

Index: trunk/phase3/js2/mwEmbed/php/maintenance/mergeJavascriptMsg.php
@@ -126,14 +126,14 @@
127127 if ( file_put_contents( $fname, $str ) ) {
128128 print "\nupdated $curFileName from php\n\n";
129129 } else {
130 - die( "could not write to: " . $fname );
 130+ die( "Could not write to: " . $fname );
131131 }
132132 }
133133 // return phpOut for building msgSet in outer function
134134 return $outPhp;
135135
136136 } else {
137 - print "could not get any json vars from:$curFileName \n";
 137+ print "Could not get any json vars from: $curFileName\n";
138138 return '';
139139 }
140140 }
@@ -170,9 +170,11 @@
171171 $result .= $char . $newline . str_repeat( $tab, $tabcount );
172172 }
173173 break;
 174+/* FIXME: this will change "key" : "message:" to "key" : "messages : ". Not intended.
 175+ now "key" : "message" will become "key":"message:", but that's not too big of a problem.
174176 case ':':
175177 $result .= ' ' . $char . ' ';
176 - break;
 178+ break; */
177179 case '"':
178180 $inquote = !$inquote;
179181 $result .= $char;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r55290* added support for merging php -> js (already supported js -> php)dale23:49, 18 August 2009

Comments

#Comment by Mdale (talk | contribs)   18:06, 27 August 2009

this has been fixed in: r55631

Status & tagging log