r55631 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r55630‎ | r55631 | r55632 >
Date:16:56, 27 August 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed : spaces to only look outside of "quotes"
Modified paths:
  • /trunk/phase3/js2/mwEmbed/php/maintenance/mergeJavascriptMsg.php (modified) (history)

Diff [purge]

Index: trunk/phase3/js2/mwEmbed/php/maintenance/mergeJavascriptMsg.php
@@ -170,11 +170,13 @@
171171 $result .= $char . $newline . str_repeat( $tab, $tabcount );
172172 }
173173 break;
174 -/* FIXME: this will change "key" : "message:" to "key" : "messages : ". Not intended.
175 - now "key" : "message" will become "key":"message:", but that's not too big of a problem.
176 - case ':':
177 - $result .= ' ' . $char . ' ';
178 - break; */
 174+ case ':':
 175+ if($inquote){
 176+ $result .= $char;
 177+ }else{
 178+ $result .= ' ' . $char . ' ';
 179+ }
 180+ break;
179181 case '"':
180182 $inquote = !$inquote;
181183 $result .= $char;

Status & tagging log