r55515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r55514‎ | r55515 | r55516 >
Date:01:25, 23 August 2009
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 20317) Cleaned up default main page link accesskey settings

Cleanup from r46398 (bug 17184) which moved the accesskey from 'n-mainpage' onto 'p-logo' to avoid duplicating the access key on both the logo and the main page.

Putting the 'z' accesskey default on 'n-mainpage-description' now instead of p-logo; also kept 'z' for 'n-mainpage' for back-compat for people with older customized sidebars which don't specify mainpage-description.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
——@@ -3179,8 +3179,9 @@
31803180 'accesskey-search' => 'f', # do not translate or duplicate this message to other languages
31813181 'accesskey-search-go' => '', # do not translate or duplicate this message to other languages
31823182 'accesskey-search-fulltext' => '', # do not translate or duplicate this message to other languages
3183 -'accesskey-p-logo' => 'z', # do not translate or duplicate this message to other languages
3184 -'accesskey-n-mainpage' => '', # do not translate or duplicate this message to other languages
 3183+'accesskey-p-logo' => '', # do not translate or duplicate this message to other languages
 3184+'accesskey-n-mainpage' => 'z', # for back-compat... do not translate or duplicate this message to other languages
 3185+'accesskey-n-mainpage-description' => 'z', # do not translate or duplicate this message to other languages
31853186 'accesskey-n-portal' => '', # do not translate or duplicate this message to other languages
31863187 'accesskey-n-currentevents' => '', # do not translate or duplicate this message to other languages
31873188 'accesskey-n-recentchanges' => 'r', # do not translate or duplicate this message to other languages
——@@ -3243,8 +3244,9 @@
32443245 'tooltip-search' => 'Search {{SITENAME}}',
32453246 'tooltip-search-go' => 'Go to a page with this exact name if exists',
32463247 'tooltip-search-fulltext' => 'Search the pages for this text',
3247 -'tooltip-p-logo' => 'Visit the main page',
3248 -'tooltip-n-mainpage' => 'Visit the main page',
 3248+'tooltip-p-logo' => 'Visit the main page', # for back-compat
 3249+'tooltip-n-mainpage' => 'Visit the main page', # for back-compat
 3250+'tooltip-n-mainpage-description' => 'Visit the main page',
32493251 'tooltip-n-portal' => 'About the project, what you can do, where to find things',
32503252 'tooltip-n-currentevents' => 'Find background information on current events',
32513253 'tooltip-n-recentchanges' => 'The list of recent changes in the wiki',
Index: trunk/phase3/RELEASE-NOTES
——@@ -420,6 +420,7 @@
421421 * (bug 15646) Page creation notification email is not longer sent when a
422422 watched page is deleted
423423 * (bug 20358) Unprotect tab was missing accesskey; now same as protect tab.
 424+* (bug 20317) Cleaned up default main page link accesskey settings
424425
425426 == API changes in 1.16 ==
426427

Follow-up revisions

RevisionCommit summaryAuthorDate
r55519Follow-up r55513 and r55515: Add new message keys to maintenance scriptraymond07:20, 23 August 2009
r55520Follow-up r55513 and r55515: Add new message keys to maintenance script...raymond07:40, 23 August 2009
r55521Follow-up r55513 and r55515: Add new message keys to maintenance script...raymond07:42, 23 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46398(bug 17184) Duplicate "z" accesskey in MonoBook...simetrical23:09, 27 January 2009

Comments

#Comment by RockMFR (talk | contribs)   01:56, 23 August 2009

tooltip-p-logo is stilled used I think, so it doesn't need to back-compat comment.

#Comment by RockMFR (talk | contribs)   14:46, 23 August 2009

Let me re-write that in English :)

tooltip-p-logo is still used I think, so it doesn't need the back-compat comment.

Status & tagging log