r46398 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46397‎ | r46398 | r46399 >
Date:23:09, 27 January 2009
Author:simetrical
Status:ok
Tags:
Comment:
(bug 17184) Duplicate "z" accesskey in MonoBook

Also (necessarily) changed accesskey-p-logo and tooltip-p-logo so that
they actually work -- previously they were just silently ignored in
favor of duplicating {accesskey,tooltip}-n-mainpage.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -178,7 +178,7 @@
179179 <div class="portlet" id="p-logo">
180180 <a style="background-image: url(<?php $this->text('logopath') ?>);" <?php
181181 ?>href="<?php echo htmlspecialchars($this->data['nav_urls']['mainpage']['href'])?>"<?php
182 - echo $skin->tooltipAndAccesskey('n-mainpage') ?>></a>
 182+ echo $skin->tooltipAndAccesskey('p-logo') ?>></a>
183183 </div>
184184 <script type="<?php $this->text('jsmimetype') ?>"> if (window.isMSIE55) fixalpha(); </script>
185185 <?php
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2878,8 +2878,8 @@
28792879 'accesskey-search' => 'f', # do not translate or duplicate this message to other languages
28802880 'accesskey-search-go' => '', # do not translate or duplicate this message to other languages
28812881 'accesskey-search-fulltext' => '', # do not translate or duplicate this message to other languages
2882 -'accesskey-p-logo' => '', # do not translate or duplicate this message to other languages
2883 -'accesskey-n-mainpage' => 'z', # do not translate or duplicate this message to other languages
 2882+'accesskey-p-logo' => 'z', # do not translate or duplicate this message to other languages
 2883+'accesskey-n-mainpage' => '', # do not translate or duplicate this message to other languages
28842884 'accesskey-n-portal' => '', # do not translate or duplicate this message to other languages
28852885 'accesskey-n-currentevents' => '', # do not translate or duplicate this message to other languages
28862886 'accesskey-n-recentchanges' => 'r', # do not translate or duplicate this message to other languages
@@ -2941,7 +2941,7 @@
29422942 'tooltip-search' => 'Search {{SITENAME}}',
29432943 'tooltip-search-go' => 'Go to a page with this exact name if exists',
29442944 'tooltip-search-fulltext' => 'Search the pages for this text',
2945 -'tooltip-p-logo' => 'Main Page',
 2945+'tooltip-p-logo' => 'Visit the Main Page',
29462946 'tooltip-n-mainpage' => 'Visit the Main Page',
29472947 'tooltip-n-portal' => 'About the project, what you can do, where to find things',
29482948 'tooltip-n-currentevents' => 'Find background information on current events',
Index: trunk/phase3/RELEASE-NOTES
@@ -103,6 +103,7 @@
104104 * Parser tests no longer fail when $wgExternalLinkTarget is set in LocalSettings
105105 * (bug 15391) catch DBQueryErrors on external storage insertion. This avoids error
106106 messages on save were the edit in fact is saved.
 107+* (bug 17184) Remove duplicate "z" accesskey in MonoBook
107108
108109 == API changes in 1.15 ==
109110 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Follow-up revisions

RevisionCommit summaryAuthorDate
r55515* (bug 20317) Cleaned up default main page link accesskey settings...brion01:25, 23 August 2009

Status & tagging log