r54708 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54707‎ | r54708 | r54709 >
Date:11:04, 10 August 2009
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Fix silly bug in r54703 r53546
Modified paths:
  • /trunk/phase3/includes/media/GIF.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/GIF.php
@@ -24,8 +24,9 @@
2525 }
2626
2727 function getImageArea( $image, $width, $height ) {
28 - if ($metadata) {
29 - $metadata = unserialize($image->getMetadata());
 28+ $ser = $image->getMetadata()
 29+ if ($ser) {
 30+ $metadata = unserialize($ser);
3031 return $width * $height * $metadata['frameCount'];
3132 } else {
3233 return $width * $height;

Follow-up revisions

RevisionCommit summaryAuthorDate
r54710Fix E_PARSE from r54708ialex11:12, 10 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53546followup to r53545: mostrevisors-users made mandatory.purodha11:35, 20 July 2009
r54703Moar error handling for r53546werdna09:32, 10 August 2009

Comments

#Comment by Siebrand (talk | contribs)   11:10, 10 August 2009

Sorry, Andrew, not getting any better: PHP Parse error: syntax error, unexpected T_IF in /var/www/w/includes/media/GIF.php on line 28

Status & tagging log