r53545 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53544‎ | r53545 | r53546 >
Date:11:28, 20 July 2009
Author:purodha
Status:deferred
Tags:
Comment:
I18n: make 'editors' a translatable string.
Modified paths:
  • /trunk/extensions/MostRevisors/MostRevisors.i18n.php (modified) (history)
  • /trunk/extensions/MostRevisors/MostRevisors_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MostRevisors/MostRevisors_body.php
@@ -129,9 +129,11 @@
130130 if ( !is_null( $title ) ) {
131131 $skin = $wgUser->getSkin();
132132 $link = $row->page_is_redirect
133 - ? '<span class="allpagesredirect">' . $skin->makeKnownLinkObj( $title ) . '</span>'
134 - : $skin->makeKnownLinkObj( $title );
135 - $link .= " - $row->value " . wfMsg( 'mostrevisors-users' );
 133+ ? '<span class="allpagesredirect">' . $skin->makeKnownLinkObj( $title ) . '</span>'
 134+ : $skin->makeKnownLinkObj( $title );
 135+ $link .= ' ' . wfMsgExt( 'mostrevisors-users', array( 'parsemag'), $row->value );
 136+ // FIXME: check if target page of the link below exists before linking to it.
 137+ // FIXME: move brackets from code into message, see http://www.mediawiki.org/wiki/Internationalisation#Symbols.2C_colons.2C_brackets.2C_etc._are_parts_of_messages
136138 if ( $wgMostRevisorsLinkContributors == True ) $link .= " (" . $skin->makeKnownLinkObj( Title::makeTitleSafe( - 1, 'Contributors/' . $title ), wfMsg( 'mostrevisors-viewcontributors' ) ) . ")";
137139 return( "<li>{$link}</li>\n" );
138140 } else {
Index: trunk/extensions/MostRevisors/MostRevisors.i18n.php
@@ -19,11 +19,11 @@
2020 'mostrevisors-submit' => 'Go',
2121 'mostrevisors-showredir' => 'Show redirect pages',
2222 'mostrevisors-hideredir' => 'Hide redirect pages',
 23+ 'mostrevisors-users' => '- $1 {{PLURAL:$1|editor|editors}}',
2324 'mostrevisors-viewcontributors' => 'View main contributors',
2425 //'mostrevisors-text' => 'Show [[Special:MostRevisions|pages with the most revisors]], starting from [[MediaWiki:Mostrevisors-limit-few-revisors|{{MediaWiki:Mostrevisors-limit-few-revisors}} revisors]].',
2526
2627 // Settings. Do not translate these messages.
27 - 'mostrevisors-users' => 'editors',
2828 'mostrevisors-limit-few-revisors' => '1',
2929 );
3030

Follow-up revisions

RevisionCommit summaryAuthorDate
r53546followup to r53545: mostrevisors-users made mandatory.purodha11:35, 20 July 2009

Status & tagging log