r54693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54692‎ | r54693 | r54694 >
Date:01:42, 10 August 2009
Author:simetrical
Status:resolved (Comments)
Tags:
Comment:
Don't use summary attribute in TOCs

The summary attribute is obsolete in HTML 5. It wasn't serving any
useful purpose anyway, since it duplicated the h2 inside the table. (Of
course, we should really stop using <table> for TOCs altogether!)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1260,7 +1260,7 @@
12611261 global $wgJsMimeType;
12621262 $title = wfMsgHtml('toc') ;
12631263 return
1264 - '<table id="toc" class="toc" summary="' . $title .'"><tr><td>'
 1264+ '<table id="toc" class="toc"><tr><td>'
12651265 . '<div id="toctitle"><h2>' . $title . "</h2></div>\n"
12661266 . $toc
12671267 # no trailing newline, script should not be wrapped in a
Index: trunk/phase3/RELEASE-NOTES
@@ -196,6 +196,8 @@
197197 cutting-edge browsers. E.g., some inputs will be autofocused, users will
198198 not be allowed to submit forms with certain types of invalid values (like
199199 numbers outside the permitted ranges), etc.
 200+** The summary attribute has been removed from tables of contents. summary is
 201+ obsolete in HTML 5 and wasn't useful here anyway.
200202 * New hook SpecialRandomBeforeSQL allows extensions to modify or replace the SQL
201203 query used in Special:Random and subclasses, deprecating the $wgExtraRandompageSQL
202204 config variable

Follow-up revisions

RevisionCommit summaryAuthorDate
r54705Update parser tests for r54693vasilievvv10:13, 10 August 2009

Comments

#Comment by Bryan (talk | contribs)   08:30, 10 August 2009

Expected parser test results should be changed accordingly.

Status & tagging log