r54694 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54693‎ | r54694 | r54695 >
Date:01:54, 10 August 2009
Author:mrzman
Status:deferred
Tags:
Comment:
revert r54605 per comments on CodeReview
Modified paths:
  • /trunk/extensions/IndexFunction/SpecialIndex.php (modified) (history)

Diff [purge]

Index: trunk/extensions/IndexFunction/SpecialIndex.php
@@ -134,20 +134,13 @@
135135 array( 'page' => array('JOIN','page_id=in_from') )
136136 );
137137
138 - $union = $this->unionQueries( array( $pagequery, $indexquery ), false );
 138+ $union = $this->mDb->unionQueries( array( $pagequery, $indexquery ), false );
139139 $union .= $order . $limit;
140140
141141 $res = $this->mDb->query( $union, __METHOD__ );
142142 return new ResultWrapper( $this->mDb, $res );
143143 }
144 -
145 - // Copied from Database.php on MW trunk
146 - function unionQueries($sqls, $all) {
147 - $glue = $all ? ') UNION ALL (' : ') UNION (';
148 - return '('.implode( $glue, $sqls ) . ')';
149 - }
150144
151 -
152145 }
153146
154147 class SpecialIndex extends SpecialPage {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54605Copy DatabaseBase::unionQueries() from trunk for BCmrzman21:12, 7 August 2009

Status & tagging log