r54636 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54635‎ | r54636 | r54637 >
Date:17:34, 8 August 2009
Author:jan
Status:reverted
Tags:
Comment:
fixes for r54633: Add wfMsgExt for parsing PLURAL in message "newmessagesdifflink"
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -308,7 +308,7 @@
309309 if( !$usertalktitle->equals( $this->mTitle ) ) {
310310 $newmessageslink = $this->link(
311311 $usertalktitle,
312 - wfMsgHtml( 'newmessageslink' ),
 312+ wfMsgExt( 'newmessageslink', array( 'parsemag', 'escape' ) ),
313313 array(),
314314 array( 'redirect' => 'no' ),
315315 array( 'known', 'noclasses' )
@@ -316,7 +316,7 @@
317317
318318 $newmessagesdifflink = $this->link(
319319 $usertalktitle,
320 - wfMsgHtml( 'newmessagesdifflink', $newmessagescount ),
 320+ wfMsgExt( 'newmessagesdifflink', array( 'parsemag', 'escape' ), $newmessagescount ),
321321 array(),
322322 array( 'diff' => 'cur' ),
323323 array( 'known', 'noclasses' )
@@ -325,7 +325,7 @@
326326 $ntl = wfMsg(
327327 'youhavenewmessages',
328328 $newmessageslink,
329 - $newmessagesdifflink,
 329+ $newmessagesdifflink
330330 );
331331 # Disable Cache
332332 $out->setSquidMaxage( 0 );
Index: trunk/phase3/includes/Skin.php
@@ -1044,7 +1044,7 @@
10451045
10461046 $tl = $this->link(
10471047 $wgUser->getTalkPage(),
1048 - wfMsgHtml( 'newmessageslink'),
 1048+ wfMsgExt( 'newmessageslink', array( 'parsemag', 'escape' ) ),
10491049 array(),
10501050 array( 'redirect' => 'no' ),
10511051 array( 'known', 'noclasses' )
@@ -1052,7 +1052,7 @@
10531053
10541054 $dl = $this->link(
10551055 $wgUser->getTalkPage(),
1056 - wfMsgHtml( 'newmessagesdifflink', $nu ),
 1056+ wfMsgExt( 'newmessagesdifflink', array( 'parsemag', 'escape' ), $nu ),
10571057 array(),
10581058 array( 'diff' => 'cur' ),
10591059 array( 'known', 'noclasses' )
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -894,9 +894,9 @@
895895 'pagetitle' => '$1 - {{SITENAME}}', # only translate this message to other languages if you have to change it
896896 'pagetitle-view-mainpage' => '{{SITENAME}}', # only translate this message to other languages if you have to change it
897897 'retrievedfrom' => 'Retrieved from "$1"',
898 -'youhavenewmessages' => 'You have $3 $1 ($2).',
899 -'newmessageslink' => '{{PLURAL:$1|new message|new messages}}',
900 -'newmessagesdifflink' => 'last change',
 898+'youhavenewmessages' => 'You have $1 ($2).',
 899+'newmessageslink' => 'new messages',
 900+'newmessagesdifflink' => '{{PLURAL:$1|one change|$1 changes}}',
901901 'youhavenewmessagesmulti' => 'You have new messages on $1',
902902 'newtalkseparator' => ', ', # do not translate or duplicate this message to other languages
903903 'editsection' => 'edit',

Follow-up revisions

RevisionCommit summaryAuthorDate
r54733Pull back r54590, r54591, r54628, r54633, r54636, r54714 "Add after the link ...brion19:03, 10 August 2009
r54740Localisation updates for core messages from translatewiki.net...siebrand20:45, 10 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54633(fixes for r54628) Add PLURAL to "last change" messagejan16:02, 8 August 2009

Status & tagging log