r54625 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54624‎ | r54625 | r54626 >
Date:06:22, 8 August 2009
Author:shinjiman
Status:ok
Tags:
Comment:
added Windows Mobile and iPhone OS detection, bump $wgOptInStyleVersion.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/OptIn/OptIn.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/OptIn/OptIn.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/OptIn/OptIn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.php
@@ -28,7 +28,7 @@
2929 $wgOptInAlwaysShowPersonalLink = false;
3030 $wgOptInNeverShowPersonalLink = false;
3131
32 -$wgOptInStyleVersion = 7;
 32+$wgOptInStyleVersion = 8;
3333
3434 // Preferences to set when users opt in
3535 // array( prefname => value )
@@ -92,7 +92,9 @@
9393 'type' => 'dropdown',
9494 'answers' => array(
9595 'windows' => 'optin-survey-answer-os-windows',
 96+ 'windowsmobile' => 'optin-survey-answer-os-windowsmobile',
9697 'macos' => 'optin-survey-answer-os-macos',
 98+ 'iphoneos' => 'ptin-survey-answer-os-iphoneos',
9799 'linux' => 'optin-survey-answer-os-linux' ),
98100 'other' => 'optin-survey-answer-os-other' ),
99101 'res' => array(
Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.js
@@ -70,9 +70,18 @@
7171 case 'win':
7272 osIndex = 'windows';
7373 break;
 74+ case 'iemobile':
 75+ osIndex = 'windowsmobile';
 76+ break;
7477 case 'mac':
7578 osIndex = 'macos';
7679 break;
 80+ case 'iphone':
 81+ osIndex = 'iphoneos';
 82+ break;
 83+ case 'ipod':
 84+ osIndex = 'iphoneos';
 85+ break;
7786 case 'linux':
7887 osIndex = 'linux';
7988 break;
Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.i18n.php
@@ -81,7 +81,9 @@
8282 'optin-survey-answer-browser-other' => 'Other browser:',
8383 'optin-survey-question-os' => 'Which operating system do you use?',
8484 'optin-survey-answer-os-windows' => 'Windows',
 85+ 'optin-survey-answer-os-windowsmobile' => 'Windows Mobile',
8586 'optin-survey-answer-os-macos' => 'Mac OS',
 87+ 'optin-survey-answer-os-iphoneos' => 'iPhone OS',
8688 'optin-survey-answer-os-linux' => 'Linux',
8789 'optin-survey-answer-os-other' => 'Other operating system:',
8890 'optin-survey-question-res' => 'What is the resolution of your screen?',

Follow-up revisions

RevisionCommit summaryAuthorDate
r54626Follow-up r54625: Make new messages optional for translatewikiraymond07:02, 8 August 2009
r54752Merge a bunch of UsabilityInitiative fixes. This commit may mess up svn:merge...catrope22:12, 10 August 2009

Status & tagging log