r54410 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54409‎ | r54410 | r54411 >
Date:23:24, 4 August 2009
Author:brion
Status:ok
Tags:
Comment:
Add fixme note to replace 'mysql' command-line callout with proper usage of a second unbuffered DB connection
Modified paths:
  • /trunk/phase3/maintenance/populateSha1.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/populateSha1.php
@@ -56,6 +56,7 @@
5757 $batch = array();
5858
5959 if ( $method == 'pipe' ) {
 60+ // @fixme kill this and replace with a second unbuffered DB connection.
6061 global $wgDBuser, $wgDBserver, $wgDBpassword, $wgDBname;
6162 $cmd = 'mysql -u' . wfEscapeShellArg( $wgDBuser ) .
6263 ' -h' . wfEscapeShellArg( $wgDBserver ) .

Follow-up revisions

RevisionCommit summaryAuthorDate
r112735Fix comment from r54410, add rationale for using MySQL command line pipetstarling22:30, 29 February 2012

Status & tagging log