| Index: trunk/phase3/maintenance/populateImageSha1.php |
| — | — | @@ -74,7 +74,10 @@ |
| 75 | 75 | $imageTable = $dbw->tableName( 'image' ); |
| 76 | 76 | |
| 77 | 77 | if ( $method == 'pipe' ) { |
| 78 | | - // @todo FIXME: Kill this and replace with a second unbuffered DB connection. |
| | 78 | + // Opening a pipe allows the SHA-1 operation to be done in parallel |
| | 79 | + // with the database write operation, because the writes are queued |
| | 80 | + // in the pipe buffer. This can improve performance by up to a |
| | 81 | + // factor of 2. |
| 79 | 82 | global $wgDBuser, $wgDBserver, $wgDBpassword, $wgDBname; |
| 80 | 83 | $cmd = 'mysql -u' . wfEscapeShellArg( $wgDBuser ) . |
| 81 | 84 | ' -h' . wfEscapeShellArg( $wgDBserver ) . |