r54188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54187‎ | r54188 | r54189 >
Date:03:07, 2 August 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 19394) Recent changes feed items corresponding to some log entries are broken. Patch by Mormegil
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ChangesFeed.php (modified) (history)
  • /trunk/phase3/includes/FeedUtils.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FeedUtils.php
@@ -71,7 +71,7 @@
7272 $anon = new User();
7373 $accErrors = $title->getUserPermissionsErrors( 'read', $anon, true );
7474
75 - if( $title->getNamespace() >= 0 && !$accErrors ) {
 75+ if( $title->getNamespace() >= 0 && !$accErrors && $newid ) {
7676 if( $oldid ) {
7777 wfProfileIn( __FUNCTION__."-dodiff" );
7878
Index: trunk/phase3/includes/ChangesFeed.php
@@ -118,7 +118,7 @@
119119 $item = new FeedItem(
120120 $title->getPrefixedText(),
121121 FeedUtils::formatDiff( $obj ),
122 - $title->getFullURL( 'diff=' . $obj->rc_this_oldid . '&oldid=prev' ),
 122+ $obj->rc_this_oldid ? $title->getFullURL( 'diff=' . $obj->rc_this_oldid . '&oldid=prev' ) : $title->getFullURL(),
123123 $obj->rc_timestamp,
124124 ($obj->rc_deleted & Revision::DELETED_USER) ? wfMsgHtml('rev-deleted-user') : $obj->rc_user_text,
125125 $talkpage->getFullURL()
Index: trunk/phase3/RELEASE-NOTES
@@ -361,6 +361,8 @@
362362 "usercssyoucanpreview" and "userjsyoucanpreview" respectively.
363363 * (bug 12110) Split the rights for editing users' CSS/JS subpage from
364364 "editusercssjs" into "editusercss" and edituserjs" respectively.
 365+* (bug 19394) RecentChanges feed URLs for log items with no revisions
 366+ (eg Newuser, Userrights) are no longer broken
365367
366368 == API changes in 1.16 ==
367369

Status & tagging log