r54069 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54068‎ | r54069 | r54070 >
Date:03:07, 31 July 2009
Author:shinjiman
Status:reverted (Comments)
Tags:
Comment:
* (bug 20013) Added CSS class "mw-version-ext-version" is wrapped on the
extension version in Special:Version
* (bug 20014) Added CSS class "mw-listgrouprights-right-name" is wrapped on the
right name in Special:ListGroupRights
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListgrouprights.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListgrouprights.php
@@ -132,7 +132,7 @@
133133 if( $granted && ( !isset( $revoke[$permission] ) || !$revoke[$permission] ) ) {
134134 $description = wfMsgExt( 'listgrouprights-right-display', array( 'parseinline' ),
135135 User::getRightDescription( $permission ),
136 - $permission
 136+ '<span class="mw-listgrouprights-right-name">' . $permission . '</span>'
137137 );
138138 $r[] = $description;
139139 }
@@ -141,7 +141,7 @@
142142 if( $revoked ) {
143143 $description = wfMsgExt( 'listgrouprights-right-revoked', array( 'parseinline' ),
144144 User::getRightDescription( $permission ),
145 - $permission
 145+ '<span class="mw-listgrouprights-right-name">' . $permission . '</span>'
146146 );
147147 $r[] = $description;
148148 }
Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -467,7 +467,7 @@
468468 function formatCredits( $name, $version = null, $subVersion = null, $subVersionCo = null, $subVersionURL = null, $author = null, $url = null, $description = null, $descriptionMsg = null ) {
469469 $haveSubversion = $subVersion;
470470 $extension = isset( $url ) ? "[$url $name]" : $name;
471 - $version = isset( $version ) ? wfMsg( 'version-version', $version ) : '';
 471+ $version = isset( $version ) ? '<span class="mw-version-ext-version">' . wfMsg( 'version-version', $version ) . '</span>' : '';
472472 $subVersion = isset( $subVersion ) ? wfMsg( 'version-svn-revision', $subVersion, $subVersionCo ) : '';
473473 $subVersion = isset( $subVersionURL ) ? "[$subVersionURL $subVersion]" : $subVersion;
474474
Index: trunk/phase3/RELEASE-NOTES
@@ -167,6 +167,10 @@
168168 * (bug 14454) "Member of group(s)" in Special:Preferences causes language difficulties
169169 * (bug 16697) Unicode combining characters are difficult to edit in some browsers
170170 * Parser test supports uploading results to remote CodeReview instance
 171+* (bug 20013) Added CSS class "mw-version-ext-version" is wrapped on the
 172+ extension version in Special:Version
 173+* (bug 20014) Added CSS class "mw-listgrouprights-right-name" is wrapped on the
 174+ right name in Special:ListGroupRights
171175
172176 === Bug fixes in 1.16 ===
173177

Follow-up revisions

RevisionCommit summaryAuthorDate
r55000Recommit r54069 (shinjiman) after general revert r54735: * (bug 20013) Added ...raymond08:19, 14 August 2009

Comments

#Comment by Platonides (talk | contribs)   22:44, 14 March 2010

Note that only the Special:Version piece was reverted on r54069, and that ws recommited on r55000. Thus, the global status of this revision (for bugs) is Ok.

Status & tagging log