r53667 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53666‎ | r53667 | r53668 >
Date:03:01, 23 July 2009
Author:rememberthedot
Status:reverted (Comments)
Tags:
Comment:
Enabled use of the greater-than sign (">") in page titles. There is actually no reason for this character to be restricted because it does not interfere with wiki syntax or HTML tags. This will have immediate applications for articles such as "M>Tram", ">play", "The Videos 86>98", "Tour 00 >> 01 Macabre", and "I>Télé", as well as redirects for "Inequality" and "Bitwise operation".
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
@@ -1451,7 +1451,7 @@
14521452 !!end
14531453
14541454 !! test
1455 -Link containing "#<" and "#>" % as a hex sequences- these are valid section anchors
 1455+Link containing "#<" and "#>" % as hex sequences- these are valid section anchors
14561456 Example for such a section: == < ==
14571457 !! input
14581458 [[%23%3c]][[%23%3e]]
@@ -1461,11 +1461,11 @@
14621462 !! end
14631463
14641464 !! test
1465 -Link containing "<#" and ">#" as a hex sequences
 1465+Link containing "<#" and ">#" as hex sequences
14661466 !! input
14671467 [[%3c%23]][[%3e%23]]
14681468 !! result
1469 -<p>[[%3c%23]][[%3e%23]]
 1469+<p>[[%3c%23]]<a href="https://www.mediawiki.org/index.php?title=%3E&amp;action=edit&amp;redlink=1" class="new" title="&gt; (page does not exist)">&gt;#</a>
14701470 </p>
14711471 !! end
14721472
Index: trunk/phase3/includes/DefaultSettings.php
@@ -259,7 +259,7 @@
260260 *
261261 * Problematic punctuation:
262262 * []{}|# Are needed for link syntax, never enable these
263 - * <> Causes problems with HTML escaping, don't use
 263+ * < Causes problems with HTML escaping, don't use
264264 * % Enabled by default, minor problems with path to query rewrite rules, see below
265265 * + Enabled by default, but doesn't work with path to query rewrite rules, corrupted by apache
266266 * ? Enabled by default, but doesn't work with path to PATH_INFO rewrites
@@ -279,7 +279,7 @@
280280 * Theoretically 0x80-0x9F of ISO 8859-1 should be disallowed, but
281281 * this breaks interlanguage links
282282 */
283 -$wgLegalTitleChars = " %!\"$&'()*,\\-.\\/0-9:;=?@A-Z\\\\^_`a-z~\\x80-\\xFF+";
 283+$wgLegalTitleChars = " %!\"$&'()*,\\-.\\/0-9:;=?@A-Z\\\\^_`a-z~\\x80-\\xFF+>";
284284
285285
286286 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r55455Revert r53667 "Enabled use of the greater-than sign (">") in page titles. The...brion22:31, 21 August 2009

Comments

#Comment by Simetrical (talk | contribs)   16:55, 26 July 2009

Nice. Probably deserves RELEASE-NOTES?

Status & tagging log