r55455 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r55454‎ | r55455 | r55456 >
Date:22:31, 21 August 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r53667 "Enabled use of the greater-than sign (">") in page titles. There is actually no reason for this character to be restricted because it does not interfere with wiki syntax or HTML tags. This will have immediate applications for articles such as "M>Tram", ">play", "The Videos 86>98", "Tour 00 >> 01 Macabre", and "I>Télé", as well as redirects for "Inequality" and "Bitwise operation"."
Possibility of spitting raw >s into output unnerves me greatly, and could indeed be a problem depending on just where your text gets spat and what's around it. More generally allowing one half of a pair makes little sense and would simply confuse the issue.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
——@@ -1453,7 +1453,7 @@
14541454 !!end
14551455
14561456 !! test
1457 -Link containing "#<" and "#>" % as hex sequences- these are valid section anchors
 1457+Link containing "#<" and "#>" % as a hex sequences- these are valid section anchors
14581458 Example for such a section: == < ==
14591459 !! input
14601460 [[%23%3c]][[%23%3e]]
——@@ -1463,11 +1463,11 @@
14641464 !! end
14651465
14661466 !! test
1467 -Link containing "<#" and ">#" as hex sequences
 1467+Link containing "<#" and ">#" as a hex sequences
14681468 !! input
14691469 [[%3c%23]][[%3e%23]]
14701470 !! result
1471 -<p>[[%3c%23]]<a href="https://www.mediawiki.org/index.php?title=%3E&amp;action=edit&amp;redlink=1" class="new" title="> (page does not exist)">&gt;#</a>
 1471+<p>[[%3c%23]][[%3e%23]]
14721472 </p>
14731473 !! end
14741474
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -259,7 +259,7 @@
260260 *
261261 * Problematic punctuation:
262262 * []{}|# Are needed for link syntax, never enable these
263 - * < Causes problems with HTML escaping, don't use
 263+ * <> Causes problems with HTML escaping, don't use
264264 * % Enabled by default, minor problems with path to query rewrite rules, see below
265265 * + Enabled by default, but doesn't work with path to query rewrite rules, corrupted by apache
266266 * ? Enabled by default, but doesn't work with path to PATH_INFO rewrites
——@@ -279,7 +279,7 @@
280280 * Theoretically 0x80-0x9F of ISO 8859-1 should be disallowed, but
281281 * this breaks interlanguage links
282282 */
283 -$wgLegalTitleChars = " %!\"$&'()*,\\-.\\/0-9:;=?@A-Z\\\\^_`a-z~\\x80-\\xFF+>";
 283+$wgLegalTitleChars = " %!\"$&'()*,\\-.\\/0-9:;=?@A-Z\\\\^_`a-z~\\x80-\\xFF+";
284284
285285
286286 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53667Enabled use of the greater-than sign (">") in page titles. There is actually ...rememberthedot03:01, 23 July 2009

Status & tagging log