r53665 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53664‎ | r53665 | r53666 >
Date:01:23, 23 July 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
(bug 19457) $openid seems to be an array. Cleanup this code a bit, we don't need $openid because it's not used again, so just check its return directly.
Modified paths:
  • /trunk/extensions/OpenID/SpecialOpenIDServer.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/SpecialOpenIDServer.body.php
——@@ -233,9 +233,7 @@
234234
235235 # Is the user an OpenID user?
236236
237 - $openid = $this->getUserUrl( $user );
238 -
239 - if ( isset( $openid ) && strlen( $openid ) > 0 ) {
 237+ if ( !$this->getUserUrl( $user ) ) {
240238 wfDebug( "OpenID: Not one of our users; logs in with OpenID.\n" );
241239 return $request->answer( false, $this->serverUrl() );
242240 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r59041Fix regression in r53665 which broke ability to act as OpenID server....brion23:19, 13 November 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   23:21, 13 November 2009

The logic was reversed here, making it impossible to use local accounts as OpenID auth sources. Fixed in r59041.

Status & tagging log