r59041 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r59040‎ | r59041 | r59042 >
Date:23:19, 13 November 2009
Author:brion
Status:ok
Tags:
Comment:
Fix regression in r53665 which broke ability to act as OpenID server.

The logic was reversed when changing from a string check to array check, so we would refuse to act as an OpenID server for local users, instead of refusing to act as OpenID server for remotely-sourced users.
With this and the last fix, I'm now actually able to use a MediaWiki instance as an OpenID auth source for other sites (tested w/ StatusNet 0.9.x dev + OpenID plugin on PHP 5.2.11).
Modified paths:
  • /trunk/extensions/OpenID/SpecialOpenIDServer.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/SpecialOpenIDServer.body.php
——@@ -240,7 +240,7 @@
241241
242242 # Is the user an OpenID user?
243243
244 - if ( !$this->getUserUrl( $user ) ) {
 244+ if ( $this->getUserUrl( $user ) ) {
245245 wfDebug( "OpenID: Not one of our users; logs in with OpenID.\n" );
246246 return $request->answer( false, $this->serverUrl() );
247247 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53665(bug 19457) $openid seems to be an array. Cleanup this code a bit, we don't n...demon01:23, 23 July 2009

Status & tagging log