r53376 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53375‎ | r53376 | r53377 >
Date:19:27, 16 July 2009
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Fixed bug that caused the last parameter of the generated users scripts (see Skin:generateUserJs) to become corrupted from a ? being always used to append an additional parameter (which if there are already paramters breaks stuff).
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -158,7 +158,7 @@
159159 Xml::element( 'script',
160160 array(
161161 'type' => $wgJsMimeType,
162 - 'src' => "$path?" . $this->getURIDparam(),
 162+ 'src' => wfAppendQuery( $path, $this->getURIDparam() ),
163163 ),
164164 '', false
165165 )

Comments

#Comment by Mike.lifeguard (talk | contribs)   03:06, 3 August 2009

This fixes bugzilla:53376.

Status & tagging log