r53377 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53376‎ | r53377 | r53378 >
Date:19:54, 16 July 2009
Author:yaron
Status:deferred
Tags:
Comment:
Fixed overcounting by one on number of pages
Modified paths:
  • /trunk/extensions/ReplaceText/SpecialReplaceText.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ReplaceText/SpecialReplaceText.php
@@ -98,10 +98,8 @@
9999 }
100100 $jobs = array();
101101 foreach ( $wgRequest->getValues() as $key => $value ) {
102 - if ( $value == '1' ) {
103 - if ($key === 'replace') {
104 - // ignore this value
105 - } elseif ( strpos( $key, 'move-' ) !== false ) {
 102+ if ( $value == '1' && $key !== 'replace' ) {
 103+ if ( strpos( $key, 'move-' ) !== false ) {
106104 $title = Title::newFromID( substr( $key, 5 ) );
107105 $replacement_params['move_page'] = true;
108106 } else {

Status & tagging log