r53142 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53141‎ | r53142 | r53143 >
Date:18:36, 12 July 2009
Author:simetrical
Status:ok
Tags:
Comment:
Re-enable $wgHtml5

The rendering issue that prompted r53137 has been fixed in r53141.
However, everyone should be on the lookout for browsers becoming
slightly more standards-compliant when this is enabled, possibly
breaking some things. Since there are no known issues, it should be
safe to re-enable so it can get further testing. See this page for info
on the effects of different doctypes:

http://hsivonen.iki.fi/doctype/
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -875,11 +875,12 @@
876876 $wgXhtmlDefaultNamespace = 'http://www.w3.org/1999/xhtml';
877877
878878 /**
879 - * Should we output an HTML 5 doctype? This needs to be left off until some
880 - * lingering rendering issues are resolved -- apparently it switches some
881 - * browsers from "almost standards" mode to standards mode.
 879+ * Should we output an HTML 5 doctype? This mode is still experimental, but
 880+ * all indications are that it should be usable, so it's enabled by default.
 881+ * If all goes well, it will be removed and become always true before the 1.16
 882+ * release.
882883 */
883 -$wgHtml5 = false;
 884+$wgHtml5 = true;
884885
885886 /**
886887 * Permit other namespaces in addition to the w3.org default.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53137Turn off $wgHtml5 by default...simetrical17:55, 12 July 2009
r53141Remove KHTMLFixes.css...simetrical18:36, 12 July 2009

Status & tagging log