r53141 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53140‎ | r53141 | r53142 >
Date:18:36, 12 July 2009
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Remove KHTMLFixes.css

This was added more than five years ago, in r3532. It was being loaded
for WebKit as well as KHTML, and I could notice no difference in either
Chrome or Konqueror whether it was loaded or not. It was responsible
for causing display errors with an HTML 5 doctype in WebKit.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)
  • /trunk/phase3/skins/monobook/KHTMLFixes.css (deleted) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/KHTMLFixes.css
——@@ -1,4 +0,0 @@
2 -/* KHTML fix stylesheet */
3 -/* work around the horizontal scrollbars */
4 -#column-content { margin-left: 0; }
5 -
Index: trunk/phase3/skins/common/wikibits.js
——@@ -10,8 +10,6 @@
1111 var is_safari_win = is_safari && clientPC.indexOf('windows') != -1;
1212 var webkit_version = parseInt(webkit_match[1]);
1313 }
14 -var is_khtml = navigator.vendor == 'KDE' ||
15 - ( document.childNodes && !document.all && !navigator.taintEnabled );
1614 // For accesskeys; note that FF3+ is included here!
1715 var is_ff2 = /firefox\/[2-9]|minefield\/3/.test( clientPC );
1816 var is_ff2_ = /firefox\/2/.test( clientPC );
——@@ -101,8 +99,6 @@
102100 importStylesheetURI(stylepath+'/'+skin+'/Opera7Fixes.css');
103101 } else if (is_opera_95) {
104102 importStylesheetURI(stylepath+'/'+skin+'/Opera9Fixes.css');
105 - } else if (is_khtml) {
106 - importStylesheetURI(stylepath+'/'+skin+'/KHTMLFixes.css');
107103 } else if (is_ff2_) {
108104 importStylesheetURI(stylepath+'/'+skin+'/FF2Fixes.css');
109105 }
Index: trunk/phase3/RELEASE-NOTES
——@@ -124,6 +124,8 @@
125125 preprocesor level.
126126 * Added $wgShowArchiveThumbnails, allowing sysadmins to disable thumbnail
127127 display for old versions of images.
 128+* Remove five-year-old KHTMLFixes.css, which is unlikely to be relevant anymore
 129+ and was causing problems.
128130
129131 === Bug fixes in 1.16 ===
130132

Follow-up revisions

RevisionCommit summaryAuthorDate
r53142Re-enable $wgHtml5...simetrical18:36, 12 July 2009
r53143Do not load old CSS fixes for new browsers...simetrical18:52, 12 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r3532work around the horizontal scrollbar khtml buggabrielwicke15:34, 10 May 2004

Comments

#Comment by Werdna (talk | contribs)   13:14, 15 July 2009

You should have left is_khtml intact. I count it being used in 5 or 6 places, and so removing it broke preferences, search suggestions, and a few others.

Either the remaining uses need to be cleaned up, or you need to re-add is_khtml.

#Comment by Simetrical (talk | contribs)   00:54, 28 July 2009

For the record, I count no more uses on trunk. Since the variable had an incredibly misleading name and was broken by design anyway (no version range specified), I think anywhere that was using it needs to be fixed anyway.

#Comment by Simetrical (talk | contribs)   00:54, 28 July 2009

Note that this is bug 19557.

#Comment by 😂 (talk | contribs)   01:44, 16 August 2009

Marking ok. I've re-grepped trunk and can't find is_khtml anywhere.

#Comment by Simetrical (talk | contribs)   02:32, 16 August 2009

Should probably go back to "new", or maybe "resolved" ― I think "ok" is supposed to mean "this has been reviewed and is okay to scap", and should usually only be set by Tim or Brion. Tim once said that when other people set "ok" he ends up mass-reverting to "new" so he can track which revisions he's actually reviewed.

Status & tagging log