r53137 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53136‎ | r53137 | r53138 >
Date:17:55, 12 July 2009
Author:simetrical
Status:resolved
Tags:
Comment:
Turn off $wgHtml5 by default

I discovered that the HTML 5 doctype does in fact trigger standards
mode in all major browsers . . . but the old XHTML 1.0 Transitional
doctype we were using did *not*. It triggers "almost standards mode" in
some browsers. The difference is causing some rendering issues that
will have to block deployment for the moment.

See r53034, r53035, r53136.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -875,12 +875,11 @@
876876 $wgXhtmlDefaultNamespace = 'http://www.w3.org/1999/xhtml';
877877
878878 /**
879 - * Temporary setting to disable HTML 5 for the unlikely event that it causes
880 - * everything to blow up. If all goes well, should be removed (and forced
881 - * true) well before it ever makes it into a release. If set to false, go back
882 - * to serving an XHTML 1.0 Transitional doctype (per $wgDocType et al. above).
 879+ * Should we output an HTML 5 doctype? This needs to be left off until some
 880+ * lingering rendering issues are resolved -- apparently it switches some
 881+ * browsers from "almost standards" mode to standards mode.
883882 */
884 -$wgHtml5 = true;
 883+$wgHtml5 = false;
885884
886885 /**
887886 * Permit other namespaces in addition to the w3.org default.
Index: trunk/phase3/RELEASE-NOTES
@@ -54,6 +54,7 @@
5555 interface will not appear in Special:AllMessages.
5656 * $wgRegisterInternalExternals can be used to record external links pointing
5757 to same server
 58+* $wgHtml5 outputs an HTML 5 doctype instead of XHTML 1.0 Transitional.
5859
5960 === New features in 1.16 ===
6061
@@ -116,7 +117,6 @@
117118 task, to limit resource usage when the cache for a heavily-viewed article is
118119 invalidated. Requires an external daemon.
119120 * Leading > is now syntax for <blockquote>.
120 -* Switched from XHTML 1.0 Transitional to HTML 5.
121121 * (bug 19576) Moved id attribues from anchors accompanying section headers to
122122 the section headers themselves, removing the redundant anchor elements.
123123 * Removed name attribute from <a id="top"></a>.

Follow-up revisions

RevisionCommit summaryAuthorDate
r53142Re-enable $wgHtml5...simetrical18:36, 12 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53034Experimentally enable HTML 5 doctype...simetrical04:19, 10 July 2009
r53035RELEASE-NOTES for r53034simetrical04:24, 10 July 2009
r53136Fix for r53034: left off \n on doctype...simetrical16:58, 12 July 2009

Status & tagging log