r53136 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53135‎ | r53136 | r53137 >
Date:16:58, 12 July 2009
Author:simetrical
Status:ok
Tags:
Comment:
Fix for r53034: left off \n on doctype

I knew it had to be impossible to change two lines without breaking
something. :)
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1562,7 +1562,7 @@
15631563 }
15641564
15651565 if ( $wgHtml5 ) {
1566 - $ret .= '<!doctype html>';
 1566+ $ret .= "<!doctype html>\n";
15671567 } else {
15681568 $ret .= "<!DOCTYPE html PUBLIC \"$wgDocType\" \"$wgDTD\">\n";
15691569 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r53137Turn off $wgHtml5 by default...simetrical17:55, 12 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53034Experimentally enable HTML 5 doctype...simetrical04:19, 10 July 2009

Status & tagging log