r53025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53024‎ | r53025 | r53026 >
Date:00:15, 10 July 2009
Author:tparscal
Status:deferred
Tags:
Comment:
Made the form look a bit better and added a link to the opt out button.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/OptIn/OptIn.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/OptIn/OptIn.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.css
@@ -126,17 +126,19 @@
127127 padding: 0;
128128 }
129129 form#optin-survey dl {
 130+ border-top: dashed 1px silver;
130131 margin: 0;
131132 padding: 0;
 133+ margin-top: 1em;
 134+ padding-top: 1em;
132135 }
133136 form#optin-survey dl dt,
134137 form#optin-survey dl dd {
135138 margin: 0;
136139 margin-bottom: 0.5em;
137 - line-height: 2em;
138140 }
139141 form#optin-survey dl dt {
140 - font-size: large;
 142+ font-size: 1.1em;
141143 }
142144 form#optin-survey dl dd {
143145 margin-left: 2em;
@@ -145,7 +147,10 @@
146148 width: 30em;
147149 height: 4em;
148150 }
149 -form#optin-survey dl dt p,
 151+form#optin-survey dl dt p {
 152+ margin: 0;
 153+ padding: 0;
 154+}
150155 form#optin-survey dl dd p {
151156 margin: 0;
152157 padding: 0;
Index: trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php
@@ -380,7 +380,8 @@
381381 $retval .= Xml::tags(
382382 'dt',
383383 array( 'class' => 'optin-survey-submit' ),
384 - Xml::submitButton( wfMsg( 'optin-submit-out' ) )
 384+ Xml::element( 'a', array( 'name' => 'leave' ) ) .
 385+ Xml::submitButton( wfMsg( 'optin-submit-out' ) )
385386 );
386387 $retval .= Xml::closeElement( 'dl' );
387388 $wgOut->addHTML( $retval );
Index: trunk/extensions/UsabilityInitiative/OptIn/OptIn.i18n.php
@@ -36,7 +36,7 @@
3737 'optin-survey-yes' => 'Yes',
3838 'optin-survey-no' => 'No',
3939 'optin-survey-intro' => "Thank you for trying Acai Beta.
40 -We would like to know what you think about our new interface, so we would appreciate it if you filled out the optional survey below before clicking \"{{int:optin-submit-out}}\".",
 40+We would like to know what you think about our new interface, so we would appreciate it if you filled out the optional survey below before clicking \"[[#leave|{{int:optin-submit-out}}]]\".",
4141 'optin-survey-question-likedislike' => 'What did you like about the Acai Beta? What did you dislike about the Acai Beta?',
4242 'optin-survey-question-whyoptout' => 'Why are you leaving this Beta? (please select all that apply) ',
4343 'optin-survey-answer-whyoptout-hard' => 'It was too hard to use.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r53036Fix up r53025: use <a id="foo"> instead of <a name="foo">. Similar changes ha...catrope04:27, 10 July 2009

Status & tagging log