r53036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53035‎ | r53036 | r53037 >
Date:04:27, 10 July 2009
Author:catrope
Status:deferred
Tags:
Comment:
Fix up r53025: use <a id="foo"> instead of <a name="foo">. Similar changes have been made to core recently.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php
@@ -407,7 +407,7 @@
408408 $retval .= Xml::tags(
409409 'dt',
410410 array( 'class' => 'optin-survey-submit' ),
411 - Xml::element( 'a', array( 'name' => 'leave' ) ) .
 411+ Xml::element( 'a', array( 'id' => 'leave' ) ) .
412412 Xml::submitButton( wfMsg( 'optin-submit-out' ) )
413413 );
414414 $retval .= Xml::closeElement( 'dl' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53025Made the form look a bit better and added a link to the opt out button.tparscal00:15, 10 July 2009

Status & tagging log