r51717 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51716‎ | r51717 | r51718 >
Date:22:54, 10 June 2009
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Http::request() is gone in the new-upload branch. Use HttpRequest() instead.
Modified paths:
  • /branches/new-upload/phase3/includes/Import.php (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/includes/Import.php
@@ -1105,7 +1105,8 @@
11061106 # quicker and sorts out user-agent problems which might
11071107 # otherwise prevent importing from large sites, such
11081108 # as the Wikimedia cluster, etc.
1109 - $data = Http::request( $method, $url );
 1109+ $req = new HttpRequest( $url, array( 'method' => $method ) );
 1110+ $data = $req->doRequest();
11101111 if( $data !== false ) {
11111112 $file = tmpfile();
11121113 fwrite( $file, $data );

Comments

#Comment by 😂 (talk | contribs)   19:06, 11 June 2009

Marking as fixme so I don't forget

Per IRC: Http::request() shouldn't have been phased out. Instead, keep it as a simple wrapper around HttpRequest().

#Comment by 😂 (talk | contribs)   21:58, 11 June 2009

Done in r51755.

#Comment by Mdale (talk | contribs)   01:39, 12 June 2009

had to implement it slightly differently then above see r51755.. but now appears to be working ;)

Status & tagging log