r51718 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51717‎ | r51718 | r51719 >
Date:22:54, 10 June 2009
Author:tparscal
Status:deferred
Tags:
Comment:
Small CSS adjustments, changed the order of some items.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.css
@@ -94,7 +94,7 @@
9595 }
9696 div#edittoolbar div.index {
9797 float: left;
98 - width: 15%;
 98+ width: 20%;
9999 height: 125px;
100100 overflow: auto;
101101 }
@@ -114,7 +114,7 @@
115115 }
116116 div#edittoolbar div.pages {
117117 float: right;
118 - width: 85%;
 118+ width: 80%;
119119 height: 125px;
120120 overflow: auto;
121121 background-color: #FAFAFA;
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -263,7 +263,7 @@
264264 switch( chars[char].type ) {
265265 case 'break':
266266 pageDiv.append( $( '<br />' ) );
267 - break;
 267+ break;
268268 case 'link':
269269 var context = {
270270 'tool' : chars[char],
@@ -278,6 +278,7 @@
279279 .click( function() { return false; } )
280280 );
281281 pageDiv.append( '&nbsp;' );
 282+ break;
282283 }
283284 }
284285 break;
@@ -717,16 +718,16 @@
718719 ],
719720 rows: [
720721 {
 722+ 'description': { contentMsg: 'edittoolbar-help-content-italic-description' },
 723+ 'syntax': { contentMsg: 'edittoolbar-help-content-italic-syntax' },
 724+ 'result': { contentMsg: 'edittoolbar-help-content-italic-result' }
 725+ },
 726+ {
721727 'description': { contentMsg: 'edittoolbar-help-content-bold-description' },
722728 'syntax': { contentMsg: 'edittoolbar-help-content-bold-syntax' },
723729 'result': { contentMsg: 'edittoolbar-help-content-bold-result' }
724730 },
725731 {
726 - 'description': { contentMsg: 'edittoolbar-help-content-italic-description' },
727 - 'syntax': { contentMsg: 'edittoolbar-help-content-italic-syntax' },
728 - 'result': { contentMsg: 'edittoolbar-help-content-italic-result' }
729 - },
730 - {
731732 'description': { contentMsg: 'edittoolbar-help-content-bolditalic-description' },
732733 'syntax': { contentMsg: 'edittoolbar-help-content-bolditalic-syntax' },
733734 'result': { contentMsg: 'edittoolbar-help-content-bolditalic-result' }
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.i18n.php
@@ -74,14 +74,14 @@
7575 'edittoolbar-help-page-file' => 'Files',
7676 'edittoolbar-help-page-reference' => 'References',
7777 'edittoolbar-help-page-discussion' => 'Discussion',
 78+ 'edittoolbar-help-content-italic-description' => 'Italic',
 79+ 'edittoolbar-help-content-italic-syntax' => "''Italic text''",
 80+ 'edittoolbar-help-content-italic-result' => '<em>Italic text</em>',
7881 'edittoolbar-help-content-bold-description' => 'Bold',
7982 'edittoolbar-help-content-bold-syntax' => "'''Bold text'''",
8083 'edittoolbar-help-content-bold-result' => '<strong>Bold text</strong>',
81 - 'edittoolbar-help-content-italic-description' => 'Italic',
82 - 'edittoolbar-help-content-italic-syntax' => "'''Italic text'''",
83 - 'edittoolbar-help-content-italic-result' => '<em>Italic text</em>',
8484 'edittoolbar-help-content-bolditalic-description' => 'Bold &amp; italic',
85 - 'edittoolbar-help-content-bolditalic-syntax' => "'''Bold &amp; italic text'''",
 85+ 'edittoolbar-help-content-bolditalic-syntax' => "''''Bold &amp; italic text''''",
8686 'edittoolbar-help-content-bolditalic-result' => '<strong><em>Bold &amp; italic text</em></strong>',
8787 'edittoolbar-help-content-ilink-description' => 'Internal link',
8888 'edittoolbar-help-content-ilink-syntax' => '[[Page title|Link label]]<br />[[Page title]]',

Status & tagging log