r51450 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51449‎ | r51450 | r51451 >
Date:06:17, 4 June 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Revert r49941 and r50013: hackish attempted use of mIsFirst before initialisation.
Modified paths:
  • /trunk/extensions/AbuseFilter/SpecialAbuseLog.php (modified) (history)
  • /trunk/phase3/includes/Pager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Pager.php
@@ -517,8 +517,6 @@
518518 function getNavigationBar() {
519519 global $wgLang;
520520
521 - if ( $this->mIsFirst && $this->mIsLast ) return '';
522 -
523521 if( isset( $this->mNavigationBar ) ) {
524522 return $this->mNavigationBar;
525523 }
@@ -600,8 +598,6 @@
601599 function getNavigationBar() {
602600 global $wgLang;
603601
604 - if ( $this->mIsFirst && $this->mIsLast ) return '';
605 -
606602 if ( isset( $this->mNavigationBar ) ) {
607603 return $this->mNavigationBar;
608604 }
Index: trunk/extensions/AbuseFilter/SpecialAbuseLog.php
@@ -115,9 +115,8 @@
116116
117117 $pager = new AbuseLogPager( $this, $conds );
118118
119 - $body = Xml::tags( 'ul', null, $pager->getBody() );
120119 $wgOut->addHTML( $pager->getNavigationBar() .
121 - $body .
 120+ Xml::tags( 'ul', null, $pager->getBody() ) .
122121 $pager->getNavigationBar() );
123122 }
124123

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49941Fix for r49939: hide navigation links in higher levelnikerabbit11:17, 27 April 2009
r50013Workaround for undefined varible access related to r49941 -- $this->mIsFirst ...brion19:30, 28 April 2009

Status & tagging log