r51449 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51448‎ | r51449 | r51450 >
Date:06:02, 4 June 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Revert r49935 (decode character entities in namespace names) due to lack of justification on CodeReview and bug report.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -700,7 +700,6 @@
701701 $m = wfMsg( 'searchprofile-articles' );
702702 $tt = wfMsg( 'searchprofile-articles-tooltip',
703703 $wgLang->commaList( SearchEngine::namespacesAsText( SearchEngine::defaultNamespaces() ) ) );
704 - $tt = Sanitizer::decodeCharReferences( $tt ); // need to allow entities
705704 if( $this->active == 'default' ) {
706705 $out .= Xml::element( 'strong', array( 'title'=>$tt ), $m );
707706 } else {
@@ -720,7 +719,6 @@
721720 $m = wfMsg( 'searchprofile-project' );
722721 $tt = wfMsg( 'searchprofile-project-tooltip',
723722 $wgLang->commaList( SearchEngine::namespacesAsText( SearchEngine::helpNamespaces() ) ) );
724 - $tt = Sanitizer::decodeCharReferences( $tt ); // need to allow entities
725723 if( $this->active == 'help' ) {
726724 $out .= Xml::element( 'strong', array( 'title'=>$tt ), $m );
727725 } else {
Index: trunk/phase3/RELEASE-NOTES
@@ -139,7 +139,6 @@
140140 for it.
141141 * (bug 17020) Adding fallback encodings for Traditional and Simplified Chinese
142142 languages while the the text is typed as URLs.
143 -* (bug 18535) Search tab tool-tops are corrupted
144143 * (bug 17614) Prev / Next links not need on ImagePage file history if less than
145144 limit
146145 * (bug 18207) Strange spacing before [[irc:...]] links

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49935* (bug 18535) Search tab tool-tops are corruptednikerabbit07:24, 27 April 2009

Status & tagging log