r49939 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49938‎ | r49939 | r49940 >
Date:10:21, 27 April 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
* (bug 17614) Prev / Next links not need on ImagePage file history if less than limit
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -958,7 +958,12 @@
959959 if( count($this->mHist) ) {
960960 $list = new ImageHistoryList( $this->mImagePage );
961961 # Generate prev/next links
962 - $navLink = $this->getNavigationBar();
 962+ $navLink = '';
 963+
 964+ # Only add navigation links when needed
 965+ if ( !$this->mIsFirst && !$this->mIsLast ) {
 966+ $navLink = $this->getNavigationBar();
 967+ }
963968 $s = $list->beginImageHistoryList($navLink);
964969 // Skip rows there just for paging links
965970 for( $i = $this->mRange[0]; $i <= $this->mRange[1]; $i++ ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -375,6 +375,7 @@
376376 * (bug 17020) Adding fallback encodings for Traditional and Simplified Chinese
377377 languages while the the text is typed as URLs.
378378 * (bug 18535) Search tab tool-tops are corrupted
 379+* (bug 17614) Prev / Next links not need on ImagePage file history if less than limit
379380
380381 == API changes in 1.15 ==
381382 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Follow-up revisions

RevisionCommit summaryAuthorDate
r49941Fix for r49939: hide navigation links in higher levelnikerabbit11:17, 27 April 2009

Status & tagging log