r50834 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50833‎ | r50834 | r50835 >
Date:20:10, 20 May 2009
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Backport r50833 to 1.15 (fixes potential extension breakage)
Modified paths:
  • /branches/REL1_15/phase3/includes/api (modified) (history)
  • /branches/REL1_15/phase3/includes/api/ApiMain.php (modified) (history)

Diff [purge]

Index: branches/REL1_15/phase3/includes/api/ApiMain.php
@@ -190,6 +190,12 @@
191191 }
192192
193193 /**
 194+ * Only kept for backwards compatibility
 195+ * @deprecated Use isWriteMode() instead
 196+ */
 197+ public function requestWriteMode() {}
 198+
 199+ /**
194200 * Set how long the response should be cached.
195201 */
196202 public function setCacheMaxAge($maxage) {
@@ -709,4 +715,4 @@
710716 public function __toString() {
711717 return "{$this->getCodeString()}: {$this->getMessage()}";
712718 }
713 -}
\ No newline at end of file
 719+}
Property changes on: branches/REL1_15/phase3/includes/api
___________________________________________________________________
Name: svn:mergeinfo
714720 - /trunk/phase3/includes/api:48813-48814,48819,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580
715721 + /trunk/phase3/includes/api:48813-48814,48819,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470,50580,50833

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50833Re-adding ApiMain::requestWriteMode() (removed in r48901) for backwards compa...catrope20:07, 20 May 2009

Comments

#Comment by Bryan (talk | contribs)   23:01, 5 December 2009

Note that there is a fixme on r50833.

Status & tagging log