r48901 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48900‎ | r48901 | r48902 >
Date:22:22, 26 March 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Add a few FIXMEs. Inadequate i18n.
Modified paths:
  • /trunk/extensions/SimpleSecurity/SimpleSecurity_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SimpleSecurity/SimpleSecurity_body.php
@@ -259,8 +259,10 @@
260260 private function groupText( &$groups ) {
261261 $gl = $groups;
262262 $gt = array_pop( $gl );
 263+ // FIXME: use $wgLang->commaList()
 264+ // FIXME: hard coded bold. Not all scripts use this. Needs i18n support.
263265 if ( count( $groups ) > 1 ) $gt = wfMsg( 'security-manygroups', "<b>" . join( "</b>, <b>", $gl ) . "</b>", "<b>$gt</b>" );
264 - else $gt = "the <b>$gt</b> group";
 266+ else $gt = "the <b>$gt</b> group"; // FIXME: hard coded text. Needs i18n support.
265267 return $gt;
266268 }
267269

Follow-up revisions

RevisionCommit summaryAuthorDate
r50833Re-adding ApiMain::requestWriteMode() (removed in r48901) for backwards compa...catrope20:07, 20 May 2009

Status & tagging log