r50470 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50469‎ | r50470 | r50471 >
Date:06:38, 11 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
(bug 18726) Fixed double URL escaping in the links to Special:RevisionDelete in the file and page history lists on Special:Undelete.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUndelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUndelete.php
@@ -1166,7 +1166,7 @@
11671167 $revdlink = Xml::tags( 'span', array( 'class'=>'mw-revdelundel-link' ),
11681168 '('.wfMsgHtml('rev-delundel').')' );
11691169 } else {
1170 - $query = array( 'target' => $this->mTargetObj->getPrefixedUrl(),
 1170+ $query = array( 'target' => $this->mTargetObj->getPrefixedDBkey(),
11711171 'artimestamp' => $ts
11721172 );
11731173 $revdlink = $sk->revDeleteLink( $query, $rev->isDeleted( Revision::DELETED_RESTRICTED ) );
@@ -1208,7 +1208,7 @@
12091209 // If revision was hidden from sysops
12101210 $revdlink = Xml::tags( 'span', array( 'class'=>'mw-revdelundel-link' ), '('.wfMsgHtml('rev-delundel').')' );
12111211 } else {
1212 - $query = array( 'target' => $this->mTargetObj->getPrefixedUrl(),
 1212+ $query = array( 'target' => $this->mTargetObj->getPrefixedDBkey(),
12131213 'fileid' => $row->fa_id
12141214 );
12151215 $revdlink = $sk->revDeleteLink( $query, $file->isDeleted( File::DELETED_RESTRICTED ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r50471Backported r50470: fixes bug 18726, double URL escaping in the links to Speci...tstarling06:42, 11 May 2009

Status & tagging log