r50471 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50470‎ | r50471 | r50472 >
Date:06:42, 11 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Backported r50470: fixes bug 18726, double URL escaping in the links to Special:RevisionDelete in the file and page history lists on Special:Undelete.
Modified paths:
  • /branches/REL1_15/phase3 (modified) (history)
  • /branches/REL1_15/phase3/includes (modified) (history)
  • /branches/REL1_15/phase3/includes/api (modified) (history)
  • /branches/REL1_15/phase3/includes/specials (modified) (history)
  • /branches/REL1_15/phase3/includes/specials/SpecialUndelete.php (modified) (history)

Diff [purge]

Property changes on: branches/REL1_15/phase3/includes/api
___________________________________________________________________
Name: svn:mergeinfo
11 - /trunk/phase3/includes/api:48813-48814,48819,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328
22 + /trunk/phase3/includes/api:48813-48814,48819,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470
Index: branches/REL1_15/phase3/includes/specials/SpecialUndelete.php
@@ -1141,7 +1141,7 @@
11421142 // If revision was hidden from sysops
11431143 $revdlink = Xml::tags( 'span', array( 'class'=>'mw-revdelundel-link' ), '('.wfMsgHtml('rev-delundel').')' );
11441144 } else {
1145 - $query = array( 'target' => $this->mTargetObj->getPrefixedUrl(),
 1145+ $query = array( 'target' => $this->mTargetObj->getPrefixedDBkey(),
11461146 'artimestamp[]' => $ts
11471147 );
11481148 $revdlink = $sk->revDeleteLink( $query, $rev->isDeleted( Revision::DELETED_RESTRICTED ) );
@@ -1183,7 +1183,7 @@
11841184 // If revision was hidden from sysops
11851185 $revdlink = Xml::tags( 'span', array( 'class'=>'mw-revdelundel-link' ), '('.wfMsgHtml('rev-delundel').')' );
11861186 } else {
1187 - $query = array( 'target' => $this->mTargetObj->getPrefixedUrl(),
 1187+ $query = array( 'target' => $this->mTargetObj->getPrefixedDBkey(),
11881188 'fileid' => $row->fa_id
11891189 );
11901190 $revdlink = $sk->revDeleteLink( $query, $file->isDeleted( File::DELETED_RESTRICTED ) );
Property changes on: branches/REL1_15/phase3/includes/specials
___________________________________________________________________
Name: svn:mergeinfo
11911191 - /trunk/phase3/includes/specials:48836,48886,48892,48989,48992-48993,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328
/trunk/phase3/includes/specials/specials:48993
11921192 + /trunk/phase3/includes/specials:48836,48886,48892,48989,48992-48993,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470
/trunk/phase3/includes/specials/specials:48993
Property changes on: branches/REL1_15/phase3/includes
___________________________________________________________________
Name: svn:mergeinfo
11931193 - /trunk/phase3/includes:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328
/trunk/phase3/includes/specials:48993
11941194 + /trunk/phase3/includes:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470
/trunk/phase3/includes/specials:48993
Property changes on: branches/REL1_15/phase3
___________________________________________________________________
Name: svn:mergeinfo
11951195 - /trunk/phase3:48814,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328
11961196 + /trunk/phase3:48814,48836,48886,48892,48909,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50470(bug 18726) Fixed double URL escaping in the links to Special:RevisionDelete ...tstarling06:38, 11 May 2009

Status & tagging log