r49019 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49018‎ | r49019 | r49020 >
Date:17:16, 29 March 2009
Author:siebrand
Status:reverted (Comments)
Tags:
Comment:
Replace tree dots by ellipsis
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -634,7 +634,7 @@
635635 'qbpageinfo' => 'Context',
636636 'qbmyoptions' => 'My pages',
637637 'qbspecialpages' => 'Special pages',
638 -'moredotdotdot' => 'More...',
 638+'moredotdotdot' => 'More…',
639639 'mypage' => 'My page',
640640 'mytalk' => 'My talk',
641641 'anontalk' => 'Talk for this IP',
@@ -1011,7 +1011,7 @@
10121012 'newpassword' => 'New password:',
10131013 'retypenew' => 'Retype new password:',
10141014 'resetpass_submit' => 'Set password and log in',
1015 -'resetpass_success' => 'Your password has been changed successfully! Now logging you in...',
 1015+'resetpass_success' => 'Your password has been changed successfully! Now logging you in…',
10161016 'resetpass_bad_temporary' => 'Invalid temporary password.
10171017 You may have already successfully changed your password or requested a new temporary password.',
10181018 'resetpass_forbidden' => 'Passwords cannot be changed',
@@ -2348,14 +2348,14 @@
23492349 'watchmethod-recent' => 'checking recent edits for watched pages',
23502350 'watchmethod-list' => 'checking watched pages for recent edits',
23512351 'watchlistcontains' => 'Your watchlist contains $1 {{PLURAL:$1|page|pages}}.',
2352 -'iteminvalidname' => "Problem with item '$1', invalid name...",
 2352+'iteminvalidname' => "Problem with item '$1', invalid name…",
23532353 'wlnote' => "Below {{PLURAL:$1|is the last change|are the last '''$1''' changes}} in the last {{PLURAL:$2|hour|'''$2''' hours}}.",
23542354 'wlshowlast' => 'Show last $1 hours $2 days $3',
23552355 'watchlist-options' => 'Watchlist options',
23562356
23572357 # Displayed when you click the "watch" button and it is in the process of watching
2358 -'watching' => 'Watching...',
2359 -'unwatching' => 'Unwatching...',
 2358+'watching' => 'Watching…',
 2359+'unwatching' => 'Unwatching…',
23602360
23612361 'enotif_mailer' => '{{SITENAME}} Notification Mailer',
23622362 'enotif_reset' => 'Mark all pages visited',
@@ -2880,7 +2880,7 @@
28812881 'import-comment' => 'Comment:',
28822882 'importtext' => 'Please export the file from the source wiki using the [[Special:Export|export utility]].
28832883 Save it to your computer and upload it here.',
2884 -'importstart' => 'Importing pages...',
 2884+'importstart' => 'Importing pages…',
28852885 'import-revision-count' => '$1 {{PLURAL:$1|revision|revisions}}',
28862886 'importnopages' => 'No pages to import.',
28872887 'importfailed' => 'Import failed: <nowiki>$1</nowiki>',

Follow-up revisions

RevisionCommit summaryAuthorDate
r51407Reverted r49019, unnecessary use of the ellipsis character, per CRtstarling15:10, 3 June 2009

Comments

#Comment by Tim Starling (talk | contribs)   17:31, 26 May 2009

Three against and zero in favour on #mediawiki. Is there some good reason to use the ellipsis character that we're missing?

#Comment by Siebrand (talk | contribs)   08:11, 27 May 2009

It is used for consistency reasons. Its usage also appears correct here. It could be replaced with a single dot (instead of 3 separate dots). From Wikipedia: "Ellipsis (plural ellipses; from the Greek: ἔλλειψις, élleipsis, "omission") is a term in printing and writing that refers to a mark or series of marks that usually indicate an intentional omission of a word or a phrase from the original text. An ellipsis can also be used to indicate a pause in speech, an unfinished thought or, at the end of a sentence, a trailing off into silence (aposiopesis)."

#Comment by Tim Starling (talk | contribs)   08:49, 27 May 2009

Consistency with what? I know what an ellipsis is, they existed a long time before the invention of unicode and they're adequately rendered using three separate dots. The issues with the single unicode character are that it's hard to edit, it looks bad or fail entirely on monospace environments such as text browsers, it's likely to fail on devices with small font sets such as phones, and that using three separate periods apparently looks perfectly good on all displays and has caused no complaints in all the years we've been using it.

Status & tagging log