r49018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49017‎ | r49018 | r49019 >
Date:17:13, 29 March 2009
Author:simetrical
Status:resolved
Tags:
Comment:
Pass query directly to getLinkUrl()
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -572,14 +572,13 @@
573573 if ( $rc_type != RC_NEW ) {
574574 $curLink = $this->message['cur'];
575575 } else {
576 - $curUrl = wfUrlencode( wfAppendQuery( $rc->getTitle()->getLinkUrl(), $querycur ) );
 576+ $curUrl = wfUrlencode( $rc->getTitle()->getLinkUrl( $querycur ) );
577577 $curLink = "<a href=\"$curUrl\" tabindex=\"{$baseRC->counter}\">{$this->message['cur']}</a>";
578578 }
579579 $diffLink = $this->message['diff'];
580580 } else {
581 - $url = $rc->getTitle()->getLinkUrl();
582 - $diffUrl = wfUrlencode( wfAppendQuery( $url, $querydiff ) );
583 - $curUrl = wfUrlencode( wfAppendQuery( $url, $querycur ) );
 581+ $diffUrl = wfUrlencode( $rc->getTitle()->getLinkUrl( $querydiff ) );
 582+ $curUrl = wfUrlencode( $rc->getTitle()->getLinkUrl( $querycur ) );
584583 $diffLink = "<a href=\"$diffUrl\" tabindex=\"{$baseRC->counter}\">{$this->message['diff']}</a>";
585584 $curLink = "<a href=\"$curUrl\" tabindex=\"{$baseRC->counter}\">{$this->message['cur']}</a>";
586585 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r49645Fix braindead wrong escaping from r49017, r49018...simetrical17:07, 19 April 2009

Status & tagging log