r48799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48798‎ | r48799 | r48800 >
Date:09:30, 25 March 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r47521 "(bug 15625) Make login/logout icons link to the projects in question :-)"
In many cases this would pop over to different languages unexpectedly, not really ideal.
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuthHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthHooks.php
@@ -132,7 +132,7 @@
133133 $url .= "?$querystring";
134134 }
135135
136 - $icon = Xml::element( 'img',
 136+ $inject_html .= Xml::element( 'img',
137137 array(
138138 'src' => $url,
139139 'alt' => $alt,
@@ -141,12 +141,6 @@
142142 'height' => 20,
143143 'style' => 'border: 1px solid #ccc;',
144144 ) );
145 -
146 - $inject_html .= Xml::tags( 'a',
147 - array(
148 - 'href' => $wiki->getUrl(''),
149 - 'title' => $alt,
150 - ), $icon );
151145 }
152146
153147 $inject_html .= '</p></div>';
@@ -269,7 +263,7 @@
270264 $url .= "?logout=1&token=$loginToken";
271265 }
272266
273 - $icon = Xml::element( 'img',
 267+ $inject_html .= Xml::element( 'img',
274268 array(
275269 'src' => $url,
276270 'alt' => $alt,
@@ -278,12 +272,6 @@
279273 'height' => 20,
280274 'style' => 'border: 1px solid #ccc;',
281275 ) );
282 -
283 - $inject_html .= Xml::tags( 'a',
284 - array(
285 - 'href' => $wiki->getUrl(''),
286 - 'title' => $alt,
287 - ), $icon );
288276 }
289277
290278 $inject_html .= '</p></div>';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47521(bug 15625) Make login/logout icons link to the projects in question :-)werdna22:13, 19 February 2009

Status & tagging log