r47521 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47520‎ | r47521 | r47522 >
Date:22:13, 19 February 2009
Author:werdna
Status:reverted (Comments)
Tags:
Comment:
(bug 15625) Make login/logout icons link to the projects in question :-)
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuthHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthHooks.php
@@ -134,7 +134,7 @@
135135 $url .= "?$querystring";
136136 }
137137
138 - $inject_html .= Xml::element( 'img',
 138+ $icon = Xml::element( 'img',
139139 array(
140140 'src' => $url,
141141 'alt' => $alt,
@@ -143,6 +143,12 @@
144144 'height' => 20,
145145 'style' => 'border: 1px solid #ccc;',
146146 ) );
 147+
 148+ $inject_html .= Xml::tags( 'a',
 149+ array(
 150+ 'href' => $wiki->getUrl(''),
 151+ 'title' => $alt,
 152+ ), $icon );
147153 }
148154
149155 $inject_html .= '</p></div>';
@@ -261,7 +267,7 @@
262268 $url .= "?logout=1&token=$loginToken";
263269 }
264270
265 - $inject_html .= Xml::element( 'img',
 271+ $icon = Xml::element( 'img',
266272 array(
267273 'src' => $url,
268274 'alt' => $alt,
@@ -270,6 +276,12 @@
271277 'height' => 20,
272278 'style' => 'border: 1px solid #ccc;',
273279 ) );
 280+
 281+ $inject_html .= Xml::tags( 'a',
 282+ array(
 283+ 'href' => $wiki->getUrl(''),
 284+ 'title' => $alt,
 285+ ), $icon );
274286 }
275287
276288 $inject_html .= '</p></div>';

Follow-up revisions

RevisionCommit summaryAuthorDate
r48799Revert r47521 "(bug 15625) Make login/logout icons link to the projects in qu...brion09:30, 25 March 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   09:30, 25 March 2009

Reverted in r48799

Status & tagging log