r48415 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r48414‎ \| r48415 \| r48416 >
Date:	07:37, 15 March 2009
Author:	rotem
Status:	ok (Comments)
Tags:	todo
Comment:	Adding the first six extra namespaces ( + talk pages) to the article namespaces that can be added to collections, as they differ between wikis. More extra namespaces should be added if necessary.
Modified paths:	/trunk/extensions/Collection/Collection.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.php
—	—	@@ -61,10 +61,18 @@
62	62	NS_PROJECT_TALK,
63	63	NS_MEDIAWIKI,
64	64	NS_MEDIAWIKI_TALK,
65		~~- 100, // Portal~~
66		~~- 101, // Portal talk~~
67		~~- 102, // Author~~
68		~~- 103, // Author talk~~
	65	+ 100,
	66	+ 101,
	67	+ 102,
	68	+ 103,
	69	+ 104,
	70	+ 105,
	71	+ 106,
	72	+ 107,
	73	+ 108,
	74	+ 109,
	75	+ 110,
	76	+ 111,
69	77	);
70	78
71	79	/** Namespace for "community books" */

#Comment by Brion VIBBER (talk | contribs) 00:09, 17 March 2009

This doesn't seem to make a huge amount of sense imo.

Would it make more sense to have a blacklist of namespaces which should *not* be added?

18:31, 24 March 2009 Brion VIBBER (talk | contribs) changed the tags for r48415 [added: todo]
18:31, 24 March 2009 Brion VIBBER (talk | contribs) changed the status of r48415 [removed: fixme added: ok]
00:09, 17 March 2009 Brion VIBBER (talk | contribs) changed the status of r48415 [removed: new added: fixme]