r48416 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48415‎ | r48416 | r48417 >
Date:13:45, 15 March 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 17992) Revert crack-inspired r48399.
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2008,9 +2008,6 @@
20092009 if ( is_null( $mode ) )
20102010 $mode = $wgDirectoryMode;
20112011
2012 - if ( !is_writable( $dir ) ) {
2013 - return false;
2014 - }
20152012 return mkdir( $dir, $mode, true ); // PHP5 <3
20162013 }
20172014

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48399Check if the path is writable before trying to mkdir().demon02:17, 14 March 2009

Status & tagging log