r48159 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48158‎ | r48159 | r48160 >
Date:07:07, 8 March 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
* Fixed notice
* Added mergehistory-reason
* Fixed XHTML
* Fixed obviously unaligned table
Modified paths:
  • /trunk/phase3/includes/specials/SpecialMergeHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMergeHistory.php
@@ -165,19 +165,15 @@
166166 # in a nice little table
167167 $table =
168168 Xml::openElement( 'fieldset' ) .
 169+ wfMsgExt( 'mergehistory-merge', array('parseinline'),
 170+ $this->mTargetObj->getPrefixedText(), $this->mDestObj->getPrefixedText() ) .
169171 Xml::openElement( 'table', array( 'id' => 'mw-mergehistory-table' ) ) .
170172 "<tr>
171173 <td class='mw-label'>" .
172 - wfMsgExt( 'mergehistory-merge', array('parseinline'),
173 - $this->mTargetObj->getPrefixedText(), $this->mDestObj->getPrefixedText() ) .
 174+ Xml::label( wfMsg( 'mergehistory-reason' ), 'wpComment' ) .
174175 "</td>
175 - </tr>
176 - <tr>
177 - <td class='mw-label'>" .
178 - Xml::label( wfMsg( 'undeletecomment' ), 'wpComment' ) .
179 - "</td>
180176 <td class='mw-input'>" .
181 - Xml::input( 'wpComment', 50, $this->mComment ) .
 177+ Xml::input( 'wpComment', 50, $this->mComment, array('id' => 'wpComment') ) .
182178 "</td>
183179 </tr>
184180 <tr>
@@ -438,7 +434,7 @@
439435 return array(
440436 'tables' => array('revision','page'),
441437 'fields' => array( 'rev_minor_edit', 'rev_timestamp', 'rev_user', 'rev_user_text', 'rev_comment',
442 - 'rev_id', 'rev_page', 'rev_text_id', 'rev_len', 'rev_deleted' ),
 438+ 'rev_id', 'rev_page', 'rev_parent_id', 'rev_text_id', 'rev_len', 'rev_deleted' ),
443439 'conds' => $conds
444440 );
445441 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r48183Add mergehistory-reason, missing from r48159aaron20:13, 8 March 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   20:13, 8 March 2009

Missing message added in r48183

Status & tagging log