r48158 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r48157‎ | r48158 | r48159 >
Date:06:57, 8 March 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Fix fatal
Modified paths:
  • /trunk/phase3/includes/specials/SpecialMergeHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMergeHistory.php
——@@ -97,7 +97,7 @@
9898 );
9999 }
100100
101 - if ( $this->mTargetObj->equals( $this->mDestObj ) ) {
 101+ if ( empty($errors) && $this->mTargetObj->equals( $this->mDestObj ) ) {
102102 $errors[] = wfMsgExt( 'mergehistory-same-destination', array( 'parse' ) );
103103 }
104104

Follow-up revisions

RevisionCommit summaryAuthorDate
r48619Tweaked r48158 to show error in more casesaaron02:58, 20 March 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   02:03, 20 March 2009

Is this right? It looks like it's checking the wrong variable to me.

#Comment by Aaron Schulz (talk | contribs)   02:58, 20 March 2009

Works ok, but tweaked in r48619

Status & tagging log